-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typecast refactoring #295
Typecast refactoring #295
Conversation
Tigrov
commented
Jul 4, 2023
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ❌ |
Breaks BC? | ❌ |
Fixed issues |
PR Summary
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #295 +/- ##
============================================
- Coverage 99.12% 99.11% -0.01%
+ Complexity 192 191 -1
============================================
Files 13 13
Lines 570 565 -5
============================================
- Hits 565 560 -5
Misses 5 5
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Two type of changes in code: swap methods order and logical refactoring. Need split
- match(true) - I think this bad practice and not approved this changes. Early exit work fastest.
In the case For me |
Match with short and simple condition - good solution (as examples from other packages), but in this case we have complex conditions. |
Great work. Thanks |