Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Medium and long text support for mysql #228

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

darkdef
Copy link
Contributor

@darkdef darkdef commented Feb 5, 2023

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️
Fixed issues #2

@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (add9679) 99.08% compared to head (e2b8528) 99.08%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #228   +/-   ##
=========================================
  Coverage     99.08%   99.08%           
  Complexity      186      186           
=========================================
  Files            13       13           
  Lines           548      548           
=========================================
  Hits            543      543           
  Misses            5        5           
Impacted Files Coverage Δ
src/QueryBuilder.php 100.00% <ø> (ø)
src/Schema.php 99.60% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@darkdef
Copy link
Contributor Author

darkdef commented Feb 5, 2023

Now it's draft. Need add recognize leghth for tiny, medum, long and other types of text for mysql only

@darkdef darkdef marked this pull request as draft February 5, 2023 17:28
@darkdef
Copy link
Contributor Author

darkdef commented Feb 11, 2023

Need other solution base on length of TYPE_TEXT
Without crutches. Need refactoring - \Yiisoft\Db\QueryBuilder\AbstractQueryBuilder::getColumnType

For information:
yiisoft/yii2#9585
https://dev.mysql.com/doc/refman/8.0/en/storage-requirements.html
https://github.com/nkovacs/yii2-mysql/blob/master/Schema.php

@darkdef darkdef changed the title Medium and long text support for mysql [Draft] Medium and long text support for mysql Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant