Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move methods from Command to AbstractPDOCommand #283

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 5, 2023

Related with yiisoft/db#770

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (997ae8b) 98.53% compared to head (61e446c) 98.48%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #283      +/-   ##
============================================
- Coverage     98.53%   98.48%   -0.05%     
+ Complexity      215      205      -10     
============================================
  Files            15       15              
  Lines           615      596      -19     
============================================
- Hits            606      587      -19     
  Misses            9        9              
Files Coverage Δ
src/Command.php 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Nov 5, 2023

PR Summary

  • Removed Unused Elements in Command.php
    Throughout the file Command.php, various aspects that were no longer needed were removed. These include imports and sections of commented out code that are not being used for anything.

  • Deleted Redundant Methods
    This pull request also includes the removal of the unused methods internalExecute and getQueryBuilder. These methods were found to be redundant and not serving a key function.

  • Eliminated Unused Exceptions
    A cleanup of the use statement in Command.php has been done with the removal of unused exceptions and throwable.

  • Unused Variable Removed
    A variable named $rawSql that was present in the internalExecute method but unused, has been removed ensuring cleaner and more efficient code.

  • Removed Redundant Method
    The redundant showDatabases method within Command.php was also removed to streamline the code and improve readability.

@Tigrov Tigrov marked this pull request as ready for review November 5, 2023 07:34
@Tigrov Tigrov merged commit 9f3d91c into master Nov 7, 2023
19 checks passed
@Tigrov Tigrov deleted the move-methods-from-Command-to-AbstractPdoCommand branch November 7, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants