Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove onePopulate() and allPopulate() methods #380

Merged
merged 5 commits into from
Aug 24, 2024
Merged

Remove onePopulate() and allPopulate() methods #380

merged 5 commits into from
Aug 24, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Aug 23, 2024

Use one() and all() methods instead

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ✔️
Fixed issues #286

@codecov Codecov
Copy link

codecov bot commented Aug 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.36%. Comparing base (721cbf2) to head (026dccd).
Report is 1 commits behind head on master.

Files Patch % Lines
src/ActiveQuery.php 75.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #380      +/-   ##
============================================
- Coverage     87.42%   87.36%   -0.06%     
+ Complexity      598      595       -3     
============================================
  Files            17       17              
  Lines          1423     1417       -6     
============================================
- Hits           1244     1238       -6     
  Misses          179      179

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Tigrov and others added 3 commits August 23, 2024 12:48
@Tigrov Tigrov added the status:code review The pull request needs review. label Aug 23, 2024
@Tigrov Tigrov requested a review from a team August 23, 2024 05:53
@Tigrov Tigrov merged commit 675deff into master Aug 24, 2024
28 of 30 checks passed
@Tigrov Tigrov deleted the remove-onepopulate-allpopulate branch August 24, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tigrov @samdark @StyleCIBot