Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relations via array #375
Relations via array #375
Changes from 15 commits
5f01c9a
671082c
48a060d
4851017
93405ec
7bd8f38
42e5f25
28f13f6
886156c
5db311b
e9021c7
0bccd2c
72754f9
025674f
34f465b
b6eed37
94302e0
fc72f1c
e7fe2e2
920d59e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add constant
TYPE_ARRAY
toSchemaInterface
in Yii DB?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, plan to move
TYPE_ARRAY
andTYPE_BIT
fromdb-pgsql
todb
package. After it can be replaced to the constant.Check warning on line 576 in src/ActiveRelationTrait.php
Codecov / codecov/patch
src/ActiveRelationTrait.php#L575-L576
Check warning on line 579 in src/ActiveRelationTrait.php
Codecov / codecov/patch
src/ActiveRelationTrait.php#L578-L579