Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the factory with an instance or Closure #365

Merged
merged 7 commits into from
Jun 23, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jun 21, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️
Fixed issues #364

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.35%. Comparing base (7a9b1fe) to head (b737ff1).
Report is 2 commits behind head on master.

Files Patch % Lines
src/ActiveQuery.php 86.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #365      +/-   ##
============================================
+ Coverage     86.27%   86.35%   +0.07%     
- Complexity      595      598       +3     
============================================
  Files            13       13              
  Lines          1399     1407       +8     
============================================
+ Hits           1207     1215       +8     
  Misses          192      192              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/ActiveQuery.php Outdated Show resolved Hide resolved
@Tigrov Tigrov merged commit e3c7c6e into master Jun 23, 2024
57 checks passed
@Tigrov Tigrov deleted the replace-factory-with-closure branch June 23, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants