Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor populateRelation() #361

Merged
merged 10 commits into from
Jul 4, 2024
Merged

Refactor populateRelation() #361

merged 10 commits into from
Jul 4, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jun 5, 2024

Q A
Is bugfix? ✔️/❌
New feature?
Breaks BC?
Fixed issues #308

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.19%. Comparing base (e9708de) to head (ed0adf1).

Files Patch % Lines
src/ActiveRelationTrait.php 93.10% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #361      +/-   ##
============================================
+ Coverage     86.20%   87.19%   +0.99%     
+ Complexity      608      591      -17     
============================================
  Files            17       17              
  Lines          1428     1398      -30     
============================================
- Hits           1231     1219      -12     
+ Misses          197      179      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review June 9, 2024 01:57
@samdark samdark requested review from darkdef and terabytesoftw June 11, 2024 16:25
@Tigrov Tigrov merged commit 8b686a0 into master Jul 4, 2024
56 checks passed
@Tigrov Tigrov deleted the refactor-populateRelation branch July 4, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants