Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ActiveQuery::removeDuplicatedModels() to separate ArrayAccess implementation #345

Merged
merged 4 commits into from
May 25, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented May 24, 2024

Q A
Is bugfix? ✔️/❌
New feature?
Breaks BC?
Fixed issues #308

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 64.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 87.16%. Comparing base (ab3c08b) to head (09830cc).

Files Patch % Lines
src/ActiveQuery.php 64.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #345      +/-   ##
============================================
- Coverage     87.36%   87.16%   -0.20%     
  Complexity      607      607              
============================================
  Files            13       13              
  Lines          1393     1395       +2     
============================================
- Hits           1217     1216       -1     
- Misses          176      179       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov merged commit e33858b into master May 25, 2024
54 of 57 checks passed
@Tigrov Tigrov deleted the refactor-removeDuplicatedModels branch May 25, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants