Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions workflows. #295

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Update actions workflows. #295

merged 4 commits into from
Feb 5, 2024

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

Copy link

what-the-diff bot commented Feb 5, 2024

PR Summary

  • Introduction of New Workflow Jobs
    The team has added two new jobs named psalm and psalm80 to boost our static analysis capabilities, meaning our code will be analyzed without needing to execute it. This is excellent news for spotting potential issues before they become bigger problems when the code runs.

    • As for the details, psalm operates on PHP versions 8.1, 8.2 and 8.3.
    • Meanwhile, psalm80 targets specifically PHP version 8.0, and it comes with a custom configuration.
  • Modification of Psalm Configuration
    Our Psalm configuration file, psalm.xml, got an update. A particular issue handler <RiskyTruthyFalsyComparison> is included with its error level set to suppress to prevent it from intervening unnecessarily.

  • Addition of a Custom Psalm Configuration
    The addition of the psalm80.xml file allows us to have a tailored psalm configuration for our needs.

  • Enhancements in Rector Configuration
    The rector.php file went through some changes for better code maintenance.

    • Importing various Rector class functionalities, including error handling, function transformation, and property read-only status configuration to achieve elegant and efficient PHP code.
    • These classes were added to the $rectorConfig->skip() method aiming for a more refined selection of code sections to be analyzed.

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (95f115f) 0.00% compared to head (9e6b316) 88.63%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master     #295       +/-   ##
=============================================
+ Coverage          0   88.63%   +88.63%     
- Complexity        0      575      +575     
=============================================
  Files             0        7        +7     
  Lines             0     1302     +1302     
=============================================
+ Hits              0     1154     +1154     
- Misses            0      148      +148     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@terabytesoftw terabytesoftw merged commit 4d3ef78 into master Feb 5, 2024
57 checks passed
@terabytesoftw terabytesoftw deleted the fix-actions branch February 5, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant