The method allPopulate in ActiveQuery will execute populate twice during execution

[niqingyang]

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	✔️/❌
Fixed issues	The method allPopulate in ActiveQuery will execute populate twice during execution #286

[what-the-diff]

PR Summary

• Simplification of 'allPopulate()' method in ActiveQuery.php
  The previous version of the allPopulate() method used to populate rows and carry out additional checks to ensure they weren't empty. With this update, this process got simpler as we replaced this logic with a direct call to the all() method for a more efficient execution.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a9097f1) 87.70% compared to head (f95a71d) 87.67%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #289      +/-   ##
============================================
- Coverage     87.70%   87.67%   -0.03%     
+ Complexity      595      594       -1     
============================================
  Files             7        7              
  Lines          1326     1323       -3     
============================================
- Hits           1163     1160       -3     
  Misses          163      163              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Tigrov]

Sorry for the long response. Perhaps we should remove the allPopulate() method as this is the same as all().

Related with:

• Restore Query::one interface db#798

[niqingyang]

Sorry for the long response. Perhaps we should remove the method as this is the same as .allPopulate()``all()

Related with:

• Restore Query::one interface db#798

Yes, it looks better this way