Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test BaseActiveRecord::getOldAttribute() after insert and update #277

Merged
merged 2 commits into from
Dec 16, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Dec 14, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues #1

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41c6691) 87.75% compared to head (8bd3e6f) 88.49%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #277      +/-   ##
============================================
+ Coverage     87.75%   88.49%   +0.73%     
- Complexity      598      686      +88     
============================================
  Files             7        7              
  Lines          1331     1573     +242     
============================================
+ Hits           1168     1392     +224     
- Misses          163      181      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Dec 14, 2023

PR Summary

  • Addition of a New Test Method
    A new method named testOldAttributeAfterInsertAndUpdate has been added to the ActiveQueryTest.php file. This method evaluates the performance of getOldAttribute function under the Customer class. Essentially, it creates a new Customer instance, sets its attributes, saves it, and monitors any changes to the 'name' attribute, specifically checking its previous values before and after any updates.

@samdark samdark added the type:test Test label Dec 14, 2023
@Tigrov Tigrov merged commit 6d9864b into master Dec 16, 2023
51 of 53 checks passed
@Tigrov Tigrov deleted the test-old-attribute-after-insert-and-update branch December 16, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants