Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not catch an Exception in isset() of magic properties #276

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Dec 14, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #9

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41c6691) 87.75% compared to head (beb99d7) 87.75%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #276   +/-   ##
=========================================
  Coverage     87.75%   87.75%           
  Complexity      598      598           
=========================================
  Files             7        7           
  Lines          1331     1331           
=========================================
  Hits           1168     1168           
  Misses          163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Dec 14, 2023

PR Summary

  • Enhanced Error Handling in BaseActiveRecordTrait.php
    Incorporated additional safety measures to manage errors in this file. Specifically, improvements have been introduced to handle errors when checking for a property’s existence, without causing the program to crash.

  • Expanded Test Coverage in ActiveRecordTest.php
    To ensure reliability and robustness of the code, additional tests were added. These tests are designed to assess how well the code handles errors. Particularly, the cases when an operation could potentially divide by zero are being checked. New tests also check the program's response to situations when there is an attempt to access properties that do not exist.

  • New Functionality in Cat.php
    Introduced a new function that allows the interaction with properties that might not have been defined. This grants an improved flexibility when working with properties for the 'Cat' class.

@Tigrov Tigrov merged commit c78469c into master Dec 16, 2023
53 of 55 checks passed
@Tigrov Tigrov deleted the throwable-magic-properties branch December 16, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants