Throw UnknownPropertyException when setting unknown property (#275)

yiisoft · Dec 16, 2023 · 813da82 · 813da82
1 parent cdcca08
commit 813da82
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/BaseActiveRecordTrait.php b/src/BaseActiveRecordTrait.php
@@ -206,6 +206,8 @@ public function __set(string $name, mixed $value): void
         if (method_exists($this, 'get' . ucfirst($name))) {
             throw new InvalidCallException('Setting read-only property: ' . static::class . '::' . $name);
         }
+
+        throw new UnknownPropertyException('Setting unknown property: ' . static::class . '::' . $name);
     }
 
     /**

diff --git a/tests/ActiveRecordTest.php b/tests/ActiveRecordTest.php
@@ -25,6 +25,7 @@
 use Yiisoft\Db\Exception\InvalidArgumentException;
 use Yiisoft\Db\Exception\InvalidCallException;
 use Yiisoft\Db\Exception\InvalidConfigException;
+use Yiisoft\Db\Exception\UnknownPropertyException;
 use Yiisoft\Db\Query\Query;
 
 abstract class ActiveRecordTest extends TestCase
@@ -596,6 +597,10 @@ public function testAttributeAccess(): void
         $this->assertSame([], $customer->orderItems);
         $this->assertFalse($customer->canGetProperty('non_existing_property'));
         $this->assertFalse($customer->canSetProperty('non_existing_property'));
+
+        $this->expectException(UnknownPropertyException::class);
+        $this->expectExceptionMessage('Setting unknown property: ' . Customer::class . '::non_existing_property');
+        $customer->non_existing_property = null;
     }
 
     public function testHasAttribute(): void
-Original file line number
+Diff line change
@@ Expand Up / @@ -206,6 +206,8 @@ public function __set(string $name, mixed $value): void @@
             if (method_exists($this, 'get' . ucfirst($name))) {
                 throw new InvalidCallException('Setting read-only property: ' . static::class . '::' . $name);
             }
+            throw new UnknownPropertyException('Setting unknown property: ' . static::class . '::' . $name);
         }
         /**
@@ Expand Down @@