Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
Tigrov authored Jan 3, 2024
1 parent 801b80a commit 71b35f2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
8 changes: 1 addition & 7 deletions src/ActiveQuery.php
Original file line number Diff line number Diff line change
Expand Up @@ -108,13 +108,7 @@ class ActiveQuery extends Query implements ActiveQueryInterface
private ActiveRecordInterface|null $arInstance = null;

/**
* @param string $arClass
* @param ConnectionInterface $db
* @param ActiveRecordFactory|null $arFactory
* @param string $tableName
*
* @psalm-template T of ActiveRecordInterface
* @psalm-param class-string<T> $arClass
* @psalm-param class-string<ActiveRecordInterface> $arClass
*/
final public function __construct(
protected string $arClass,
Expand Down
4 changes: 2 additions & 2 deletions src/BaseActiveRecord.php
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ public function hasAttribute($name): bool
*
* @return ActiveQueryInterface The relational query object.
*
* @psalm-param class-string<ActiveRecordInterface> $arClass
* @psalm-param class-string<ActiveRecordInterface> $class
*/
public function hasMany(string $class, array $link): ActiveQueryInterface
{
Expand Down Expand Up @@ -365,7 +365,7 @@ public function hasMany(string $class, array $link): ActiveQueryInterface
*
* @return ActiveQueryInterface The relational query object.
*
* @psalm-param class-string<ActiveRecordInterface> $arClass
* @psalm-param class-string<ActiveRecordInterface> $class
*/
public function hasOne(string $class, array $link): ActiveQueryInterface
{
Expand Down

0 comments on commit 71b35f2

Please sign in to comment.