Fix setting value for an attribute when AR class has get method for t…

…he attribute
yiisoft · Dec 13, 2023 · 2283833 · 2283833
1 parent 41c6691
commit 2283833
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/BaseActiveRecordTrait.php b/src/BaseActiveRecordTrait.php
@@ -200,9 +200,7 @@ public function __set(string $name, mixed $value): void
                 $this->resetDependentRelations($name);
             }
             $this->attributes[$name] = $value;
-        }
-
-        if (method_exists($this, 'get' . ucfirst($name))) {
+        } elseif (method_exists($this, 'get' . ucfirst($name))) {
             throw new InvalidCallException('Setting read-only property: ' . static::class . '::' . $name);
         }
     }

diff --git a/tests/Stubs/ActiveRecord/Customer.php b/tests/Stubs/ActiveRecord/Customer.php
@@ -37,6 +37,11 @@ public function getTableName(): string
         return 'customer';
     }
 
+    public function getName(): string
+    {
+        return $this->name;
+    }
+
     public function getProfile(): ActiveQuery
     {
         return $this->hasOne(Profile::class, ['id' => 'profile_id']);