fix: tracks color #730
Merged
fix: tracks color #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yihong0618
reviewed
Oct 25, 2024
|
I see that diff is the longest distance minus the shortest distance. Looking at this data, it is indeed not zero. So I don't quite understand what this diff is used for. def diameter(self) -> float:
if self.is_valid():
return self.upper() - self.lower()
return 0
diff = length_range.diameter()
|
yihong0618
approved these changes
Oct 27, 2024
|
Thanks will dig it later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
interpolate_coloris wrong. The solution is to check whetherspecial_distance2is greater thanlength_range.upper(). If it is greater, returncolor1