fix: move Map style to outer div for full-screen map rendering
#727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
orionna319
changed the title
Map style to outer div for full-screen map rendering
yihong0618
requested review from
ben-29,
yihong0618 and
vlin
and removed request for
yihong0618
|
Draft, There is still a problem, it may not be a height problem, I will check it later and fix it |
|
Close, Please see PR 729 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR 726
move-fullscreen-bug.mp4
Remove
MAP_HEIGHTon theMapcomponent to the outerdivto solve the full screen problem caused by the hard-codedheight