Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgradable strategies #44

Open
wants to merge 2 commits into
base: feat/strategy-v2-point-1
Choose a base branch
from
Open

Upgradable strategies #44

wants to merge 2 commits into from

Conversation

alcueca
Copy link
Contributor

@alcueca alcueca commented May 23, 2023

Using UUPS to make the Strategies upgradable

There is a bit of a confusion between initialize that takes the place of the constructor, and init that allows the first funds to be provided to the contract. I reckon one of the two should be renamed, but I'm not sure which one.

@alcueca alcueca requested review from aniemerg and Sabnock01 May 23, 2023 12:36
@Sabnock01
Copy link
Contributor

initialize is pretty common for proxies so I'd change init

Sabnock01
Sabnock01 approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@Sabnock01 Sabnock01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM unless you want to change the function name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sabnock01 Sabnock01 Sabnock01 approved these changes

@aniemerg aniemerg Awaiting requested review from aniemerg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alcueca @Sabnock01