Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: network switch within action response #447

Merged
merged 26 commits into from
Sep 26, 2023

Conversation

marcomariscal
Copy link
Contributor

@marcomariscal marcomariscal commented Sep 13, 2023

Description

Allow switching to the appropriate network if the user requests a specific chain within their message. For example, "swap 1 eth to usdc on arbitrum", if the user is on mainnet.

This is handled within ActionResponse via the button labeling and function handling.

This pr also includes Arbitrum bridging to be able to test that the network switching works as intended.

Todo

  • Handle chain id as an optional parameter within the swap widget

@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for ironclad-parent ready!

Name Link
🔨 Latest commit 107180a
🔍 Latest deploy log https://app.netlify.com/sites/ironclad-parent/deploys/6512dde04203190008bae214
😎 Deploy Preview https://deploy-preview-447--ironclad-parent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marcomariscal marcomariscal marked this pull request as ready for review September 18, 2023 17:06
Copy link
Contributor

@brucedonovan brucedonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.

@marcomariscal marcomariscal merged commit 7c3b1b7 into dev Sep 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants