Make state a C++ class, formatting, other minor changes #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this context, line wiping refers to temporarily removing the contents of the current line from the screen, but not otherwise changing the line editing state. Its use case is temporarily removing the prompt to allow other output to be written, with an intent to immediately restore it once that output is complete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran things through clang-format, and reworked the linenoise functions operating on the struct to be methods on a class. Doubt it's of too much interest since it diverges things a fair bit from upstream linenoise, but figured I'd offer it just in case.
The line wiping addition is in support of trying to use this with a program that listens for input from another thread and needs to do a little orchestration to try and get the output displayed cleanly.