Benchmark crate for core features #3487
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| - name: Run master benchmark | ||
| run: cargo bench -q > ../output.log | ||
| continue-on-error: true | ||
| working-directory: yew-master/tools/benchmark-core |
There was a problem hiding this comment.
We can probably cache this somewhere (perhaps in firestore db or storage bucket, since we already use firebase) but this is fine for now
There was a problem hiding this comment.
isnt it already cached by the 2 previous steps (swatinem/rust-cache)?
There was a problem hiding this comment.
That's true. I was thinking of just downloading the expected output file so benchmark is never run when it can be avoided
There was a problem hiding this comment.
oh... well. tbh I dont think it's worth the effort haha
| @@ -0,0 +1,14 @@ | |||
| [package] | |||
There was a problem hiding this comment.
Curious, why not put it in yew's benches instead of creating a new crate?
There was a problem hiding this comment.
I don't know... 🤷♀️ well I guess I can simply move them there I guess. I tried to keep the directory architecture with the other benchmarks
There was a problem hiding this comment.
so what do you prefer? should I move the bench in the crate yew? or keep with a separate crate for consistency sake? both are fine imo i don't really care
There was a problem hiding this comment.
I'm fine either way. It doesn't really make that much of a difference and moving it now is just extra work
| <div class={classes!("hello-world")}> | ||
| <span>{"Hello"}</span> | ||
| <strong style="color:red">{"World"}</strong> | ||
| <Stuff /> | ||
| </div> |
There was a problem hiding this comment.
We clone only VTag and VComp here. Probably wanna benchmark the others too, especially VList
There was a problem hiding this comment.
Pretty sure VList is in there because there is a list of nodes.
I'm also cloning classes and style (which are also very important imo).
(and yes the <Stuff/> thingy is purely to get a VComp)
There was a problem hiding this comment.
(ah and I'm also cloning VText (Hello and World are VText I think)
There was a problem hiding this comment.
Oh, right. It's still missing a few cases though: VSuspense and VRef. Not sure if we can benchmark those
There was a problem hiding this comment.
@cecton can we benchmark those or should we just merge it in as-is?
There was a problem hiding this comment.
I could add VSuspense but not VRef
Description
Add a tool crate benchmark-core where we can run benchmarks on some basic core
features like VNode.
Related to #3431
Checklist