Update build-a-sample-app.mdx #3423
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed outdated note in getting started guide
|
Visit the preview URL for this PR (updated for commit 1d641e9): https://yew-rs--pr3423-master-cgtql0v4.web.app (expires Thu, 05 Oct 2023 21:30:37 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
futursolo
reviewed
Sep 29, 2023
| @@ -80,7 +80,7 @@ that updates its value when clicked. Replace the contents of `src/main.rs` with | |||
| :::note | |||
| The call to `yew::Renderer::<App>::new().render()` inside the `main` function starts your application and mounts | |||
| it to the page's `<body>` tag. If you would like to start your application with any dynamic | |||
| properties, you can instead use `yew::Renderer::<App>::with_props(..).render()`. | |||
There was a problem hiding this comment.
The original description is trying to say that with_props() can be used to set properties of App.
This should not be confused with with_root(), which can be used to set the root element where the renderer renders App into.
futursolo
reviewed
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed outdated note in getting started guide
Description
According to the getting started guide, yew::Renderer::::with_props(..).render() is they way to mount your component, to an element that is not .
However, after some digging i figured out that the current way to do this is using yew::Renderer::::with_root(elem).render() instead.
I have changed the corresponding line in the getting started guide.