Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clippy For Rust 1.72 #3387

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Fix Clippy For Rust 1.72 #3387

merged 2 commits into from
Aug 28, 2023

Conversation

futursolo
Copy link
Member

@futursolo futursolo commented Aug 26, 2023

Description

Fixes #0000

This pull request fixes for Rust Release 1.72.
Rust 1.72 makes From::from a must use, which effectively makes html! a must use.

I have tried various ways to suppress unused_must_use for html!.
However, it is not effective. So I added let _ = to tests.

I have also made VNode a #[must_use] so the diagnostic will be easier to understand.

Checklist

  • I have reviewed my own code
  • I have added tests

@futursolo futursolo changed the title Fix Release 1.72 Fix For Rust 1.72 Aug 26, 2023
@github-actions
Copy link

github-actions bot commented Aug 26, 2023

Visit the preview URL for this PR (updated for commit aa009ca):

https://yew-rs-api--pr3387-fix-1-72-xy2kncgx.web.app

(expires Sat, 02 Sep 2023 15:36:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@futursolo futursolo changed the title Fix For Rust 1.72 Fix Clippy For Rust 1.72 Aug 26, 2023
@github-actions
Copy link

github-actions bot commented Aug 26, 2023

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 102.317 102.317 0 0.000%
boids 175.492 175.492 0 0.000%
communication_child_to_parent 95.220 95.220 0 0.000%
communication_grandchild_with_grandparent 108.882 108.882 0 0.000%
communication_grandparent_to_grandchild 105.544 105.544 0 0.000%
communication_parent_to_child 92.693 92.693 0 0.000%
contexts 110.877 110.877 0 0.000%
counter 89.206 89.206 0 0.000%
counter_functional 89.920 89.920 0 0.000%
dyn_create_destroy_apps 92.290 92.290 0 0.000%
file_upload 103.543 103.543 0 0.000%
function_memory_game 174.312 174.312 0 0.000%
function_router 352.390 352.390 0 0.000%
function_todomvc 163.346 163.346 0 0.000%
futures 227.710 227.710 0 0.000%
game_of_life 112.298 112.298 0 0.000%
immutable 188.941 188.941 0 0.000%
inner_html 86.013 86.013 0 0.000%
js_callback 113.000 113.000 0 0.000%
keyed_list 201.198 201.198 0 0.000%
mount_point 89.206 89.206 0 0.000%
nested_list 114.496 114.496 0 0.000%
node_refs 96.162 96.162 0 0.000%
password_strength 1582.835 1582.835 0 0.000%
portals 98.236 98.236 0 0.000%
router 318.372 318.372 0 0.000%
simple_ssr 143.642 143.642 0 0.000%
ssr_router 389.573 389.573 0 0.000%
suspense 118.707 118.707 0 0.000%
timer 91.754 91.754 0 0.000%
timer_functional 100.289 100.289 0 0.000%
todomvc 143.696 143.696 0 0.000%
two_apps 89.915 89.915 0 0.000%
web_worker_fib 154.512 154.512 0 0.000%
webgl 88.527 88.527 0 0.000%

✅ None of the examples has changed their size significantly.

@github-actions
Copy link

github-actions bot commented Aug 26, 2023

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 384.113 384.246 384.166 0.034
Hello World 10 690.964 719.820 695.035 8.738
Function Router 10 2248.939 2298.006 2272.793 14.905
Concurrent Task 10 1006.775 1007.936 1007.449 0.316
Many Providers 10 1575.441 1649.507 1601.522 24.420

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 384.133 384.300 384.185 0.047
Hello World 10 690.211 722.215 695.839 9.438
Function Router 10 2233.196 2259.280 2247.474 7.860
Concurrent Task 10 1006.547 1008.210 1007.622 0.609
Many Providers 10 1562.404 1594.917 1576.554 10.647

@futursolo futursolo marked this pull request as ready for review August 26, 2023 15:55
@ranile ranile merged commit 7ef8e0d into yewstack:master Aug 28, 2023
21 checks passed
@ranile ranile added the A-yew Area: The main yew crate label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants