Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compatibility code before 1.64 #3379

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

futursolo
Copy link
Member

Description

This pull request removes compatibility code that aimed for versions before 1.64.
Since the MSRV of Yew is now 1.64, these compatibility code are no longer needed.

Checklist

  • I have reviewed my own code
  • [N/A] I have added tests

@futursolo futursolo added the A-yew Area: The main yew crate label Aug 19, 2023
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 1e2b843):

https://yew-rs-api--pr3379-remove-compat-81hy02xi.web.app

(expires Sat, 26 Aug 2023 13:26:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This can be merged once CI is green

@github-actions
Copy link

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 392.878 393.615 393.046 0.208
Hello World 10 662.714 668.194 664.840 1.756
Function Router 10 2103.696 2126.732 2114.802 6.515
Concurrent Task 10 1006.648 1008.129 1007.249 0.392
Many Providers 10 1520.513 1564.651 1542.927 18.412

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 392.904 393.118 392.999 0.069
Hello World 10 661.133 670.932 666.612 3.474
Function Router 10 2125.201 2166.064 2145.095 12.609
Concurrent Task 10 1005.884 1008.046 1007.284 0.567
Many Providers 10 1559.936 1609.993 1578.893 19.136

@github-actions
Copy link

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 102.317 102.317 0 0.000%
boids 175.508 175.508 0 0.000%
communication_child_to_parent 95.223 95.223 0 0.000%
communication_grandchild_with_grandparent 108.900 108.900 0 0.000%
communication_grandparent_to_grandchild 105.557 105.557 0 0.000%
communication_parent_to_child 92.698 92.698 0 0.000%
contexts 110.888 110.888 0 0.000%
counter 89.206 89.206 0 0.000%
counter_functional 89.921 89.921 0 0.000%
dyn_create_destroy_apps 92.292 92.292 0 0.000%
file_upload 103.541 103.541 0 0.000%
function_memory_game 174.312 174.312 0 0.000%
function_router 352.464 352.464 0 0.000%
function_todomvc 163.364 163.364 0 0.000%
futures 227.711 227.711 0 0.000%
game_of_life 112.299 112.299 0 0.000%
immutable 188.944 188.944 0 0.000%
inner_html 86.012 86.012 0 0.000%
js_callback 112.994 112.994 0 0.000%
keyed_list 201.197 201.197 0 0.000%
mount_point 89.209 89.209 0 0.000%
nested_list 114.495 114.495 0 0.000%
node_refs 96.172 96.172 0 0.000%
password_strength 1583.149 1583.149 0 0.000%
portals 98.240 98.240 0 0.000%
router 318.441 318.441 0 0.000%
simple_ssr 143.626 143.626 0 0.000%
ssr_router 389.676 389.676 0 0.000%
suspense 118.662 118.662 0 0.000%
timer 91.755 91.755 0 0.000%
timer_functional 100.290 100.290 0 0.000%
todomvc 143.699 143.699 0 0.000%
two_apps 89.916 89.916 0 0.000%
web_worker_fib 154.505 154.505 0 0.000%
webgl 88.477 88.477 0 0.000%

✅ None of the examples has changed their size significantly.

@futursolo futursolo merged commit b28e69a into yewstack:master Aug 19, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants