Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspense example with struct component #3375

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

ranile
Copy link
Member

@ranile ranile commented Aug 10, 2023

Description

Fixes #3351

Checklist

  • I have reviewed my own code
  • I have added tests

@ranile ranile added A-examples Area: The examples documentation labels Aug 10, 2023
@github-actions
Copy link

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 102.318 102.318 0 0.000%
boids 175.511 175.511 0 0.000%
communication_child_to_parent 95.221 95.221 0 0.000%
communication_grandchild_with_grandparent 108.886 108.886 0 0.000%
communication_grandparent_to_grandchild 105.538 105.538 0 0.000%
communication_parent_to_child 92.700 92.700 0 0.000%
contexts 110.885 110.885 0 0.000%
counter 89.205 89.205 0 0.000%
counter_functional 89.920 89.920 0 0.000%
dyn_create_destroy_apps 92.236 92.236 0 0.000%
file_upload 103.542 103.542 0 0.000%
function_memory_game 174.310 174.310 0 0.000%
function_router 347.930 347.930 0 0.000%
function_todomvc 163.356 163.356 0 0.000%
futures 227.708 227.708 0 0.000%
game_of_life 112.299 112.299 0 0.000%
immutable 188.926 188.926 0 0.000%
inner_html 86.013 86.013 0 0.000%
js_callback 112.995 112.995 0 0.000%
keyed_list 201.203 201.203 0 0.000%
mount_point 89.207 89.207 0 0.000%
nested_list 114.492 114.492 0 0.000%
node_refs 96.165 96.165 0 0.000%
password_strength 1582.842 1582.842 0 0.000%
portals 98.234 98.234 0 0.000%
router 314.007 314.007 0 0.000%
simple_ssr 143.644 143.644 0 0.000%
ssr_router 385.156 385.156 0 0.000%
suspense 110.230 118.703 +8.473 +7.686%
timer 91.756 91.756 0 0.000%
timer_functional 100.292 100.292 0 0.000%
todomvc 143.697 143.697 0 0.000%
two_apps 89.918 89.918 0 0.000%
web_worker_fib 154.516 154.516 0 0.000%
webgl 88.529 88.529 0 0.000%

⚠️ The following example has changed its size significantly:

examples master (KB) pull request (KB) diff (KB) diff (%)
suspense 110.230 118.703 +8.473 +7.686%

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 73eb5ba):

https://yew-rs--pr3375-struct-ctx-consumer-iwohero2.web.app

(expires Thu, 17 Aug 2023 13:16:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@ranile ranile enabled auto-merge (squash) August 11, 2023 15:37
Copy link
Member

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to not mix function component and struct in the same example as most users will only use 1 type of component in their application.

@ranile
Copy link
Member Author

ranile commented Aug 11, 2023

I think it is better to not mix function component and struct in the same example as most users will only use 1 type of component in their application.

The struct component example for contexts is like this. That's why I added the struct component to this example. I prefer to have one example that showcases both ways to doing things, especially since this is about a specific concept and only one aspect of the usage is different

@ranile ranile merged commit 05fc4cc into yewstack:master Aug 14, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-examples Area: The examples documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suspense with struct component exemple
2 participants