-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make signature of use_future_with consistent #3372
Conversation
Visit the preview URL for this PR (updated for commit e51cebb): https://yew-rs-api--pr3372-use-future-with-izg1rjo2.web.app (expires Wed, 16 Aug 2023 19:32:22 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Size Comparison
✅ None of the examples has changed their size significantly. |
Benchmark - SSRYew Master
Pull Request
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think use_prepared_state and use_transitive_state also has deps as the second argument.
Could you please update those hooks as well?
@futursolo, that is done in #3376 |
I have updated the pr comment so it will not close the original issue. |
Description
Rename
use_future_with_deps
touse_future_with
and change it's signature to bring it in line with other hooks that dependenciesSee #3371
Checklist