Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump indexmap from 1.9.3 to 2.0.0 #3322

Merged
merged 12 commits into from
Jul 29, 2023
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 29, 2023

Bumps indexmap from 1.9.3 to 2.0.0.

Changelog

Sourced from indexmap's changelog.

  • 2.0.0

    • MSRV: Rust 1.64.0 or later is now required.

    • The "std" feature is no longer auto-detected. It is included in the default feature set, or else can be enabled like any other Cargo feature.

    • The "serde-1" feature has been removed, leaving just the optional "serde" dependency to be enabled like a feature itself.

    • IndexMap::get_index_mut now returns Option<(&K, &mut V)>, changing the key part from &mut K to &K. There is also a new alternative MutableKeys::get_index_mut2 to access the former behavior.

    • The new map::Slice<K, V> and set::Slice<T> offer a linear view of maps and sets, behaving a lot like normal [(K, V)] and [T] slices. Notably, comparison traits like Eq only consider items in order, rather than hash lookups, and slices even implement Hash.

    • IndexMap and IndexSet now have sort_by_cached_key and par_sort_by_cached_key methods which perform stable sorts in place using a key extraction function.

    • IndexMap and IndexSet now have reserve_exact, try_reserve, and try_reserve_exact methods that correspond to the same methods on Vec. However, exactness only applies to the direct capacity for items, while the raw hash table still follows its own rules for capacity and load factor.

    • The Equivalent trait is now re-exported from the equivalent crate, intended as a common base to allow types to work with multiple map types.

    • The hashbrown dependency has been updated to version 0.14.

    • The serde_seq module has been moved from the crate root to below the map module.

Commits
  • 8e47be8 Merge pull request #267 from cuviper/release-2.0.0
  • ad694fb Release 2.0.0
  • b5b2814 Merge pull request #266 from cuviper/doc-capacity
  • d3ea289 Document the lower-bound semantics of capacity
  • 74e14da Merge pull request #264 from cuviper/equivalent
  • 677c605 Add a relnote for Equivalent
  • 6d83bc1 pub use equivalent::Equivalent;
  • bb48357 Merge pull request #263 from cuviper/insert_in_slot
  • c37dae6 Use hashbrown's new single-lookup insertion
  • ee71507 Merge pull request #262 from daxpedda/hashbrown-v0.14
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Jun 29, 2023
github-actions[bot]
github-actions bot previously approved these changes Jun 29, 2023
@github-actions
Copy link

github-actions bot commented Jun 29, 2023

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 102.797 103.727 +0.930 +0.904%
boids 176.727 177.647 +0.921 +0.521%
communication_child_to_parent 95.799 96.721 +0.922 +0.962%
communication_grandchild_with_grandparent 109.873 110.610 +0.737 +0.671%
communication_grandparent_to_grandchild 106.470 107.198 +0.729 +0.684%
communication_parent_to_child 93.255 94.172 +0.917 +0.983%
contexts 111.868 112.586 +0.718 +0.642%
counter 89.753 90.679 +0.926 +1.031%
counter_functional 90.496 91.422 +0.926 +1.023%
dyn_create_destroy_apps 92.846 93.772 +0.927 +0.998%
file_upload 104.103 105.029 +0.927 +0.890%
function_memory_game 175.315 176.845 +1.529 +0.872%
function_router 349.573 351.044 +1.471 +0.421%
function_todomvc 164.112 165.646 +1.533 +0.934%
futures 228.294 229.549 +1.255 +0.550%
game_of_life 112.542 114.078 +1.536 +1.365%
immutable 188.922 190.402 +1.480 +0.784%
inner_html 86.521 87.446 +0.925 +1.069%
js_callback 113.650 114.562 +0.912 +0.803%
keyed_list 202.114 203.045 +0.931 +0.460%
mount_point 89.719 90.644 +0.925 +1.031%
nested_list 114.683 116.226 +1.543 +1.345%
node_refs 96.757 97.683 +0.926 +0.957%
password_strength 1589.343 1590.266 +0.923 +0.058%
portals 99.165 99.900 +0.735 +0.742%
router 315.642 317.062 +1.420 +0.450%
simple_ssr 144.755 145.680 +0.925 +0.639%
ssr_router 387.182 388.664 +1.482 +0.383%
suspense 110.910 111.846 +0.936 +0.844%
timer 92.317 93.245 +0.928 +1.005%
timer_functional 100.857 101.787 +0.930 +0.922%
todomvc 144.222 145.760 +1.538 +1.066%
two_apps 90.396 91.322 +0.927 +1.025%
web_worker_fib 155.426 156.366 +0.940 +0.605%
webgl 88.990 89.916 +0.926 +1.040%

⚠️ The following examples have changed their size significantly:

examples master (KB) pull request (KB) diff (KB) diff (%)
counter 89.753 90.679 +0.926 +1.031%
counter_functional 90.496 91.422 +0.926 +1.023%
game_of_life 112.542 114.078 +1.536 +1.365%
inner_html 86.521 87.446 +0.925 +1.069%
mount_point 89.719 90.644 +0.925 +1.031%
nested_list 114.683 116.226 +1.543 +1.345%
timer 92.317 93.245 +0.928 +1.005%
todomvc 144.222 145.760 +1.538 +1.066%
two_apps 90.396 91.322 +0.927 +1.025%
webgl 88.990 89.916 +0.926 +1.040%

@futursolo
Copy link
Member

@dependabot rebase

Bumps [indexmap](https://github.com/bluss/indexmap) from 1.9.3 to 2.0.0.
- [Changelog](https://github.com/bluss/indexmap/blob/master/RELEASES.md)
- [Commits](indexmap-rs/indexmap@1.9.3...2.0.0)

---
updated-dependencies:
- dependency-name: indexmap
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@cecton
Copy link
Member

cecton commented Jul 29, 2023

https://github.com/dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 29, 2023

Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

github-actions[bot]
github-actions bot previously approved these changes Jul 29, 2023
@github-actions
Copy link

github-actions bot commented Jul 29, 2023

Visit the preview URL for this PR (updated for commit 9634df2):

https://yew-rs--pr3322-dependabot-cargo-ind-c2my5lfp.web.app

(expires Sat, 05 Aug 2023 12:19:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

github-actions[bot]
github-actions bot previously approved these changes Jul 29, 2023
github-actions[bot]
github-actions bot previously approved these changes Jul 29, 2023
github-actions[bot]
github-actions bot previously approved these changes Jul 29, 2023
@github-actions
Copy link

github-actions bot commented Jul 29, 2023

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 360.066 360.160 360.112 0.038
Hello World 10 685.226 691.572 686.742 1.843
Function Router 10 2186.896 2215.445 2200.924 8.806
Concurrent Task 10 1005.942 1007.952 1007.030 0.680
Many Providers 10 1551.393 1591.443 1562.540 13.772

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 392.906 401.467 393.823 2.686
Hello World 10 667.188 696.887 674.649 8.136
Function Router 10 2175.303 2235.385 2211.263 16.739
Concurrent Task 10 1006.721 1007.851 1007.312 0.340
Many Providers 10 1504.489 1583.818 1525.406 25.714

github-actions[bot]
github-actions bot previously approved these changes Jul 29, 2023
github-actions[bot]
github-actions bot previously approved these changes Jul 29, 2023
github-actions[bot]
github-actions bot previously approved these changes Jul 29, 2023
@cecton
Copy link
Member

cecton commented Jul 29, 2023

@futursolo ok I think this is ready. I updated your PR for implicit-clone 0.4.0 and MSRV to 1.64 (which is required by some dependencies somewhere I forgot which one...) and updated the stderr files of the yew-macro

I'll let you verify and merge

Copy link
Member

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@futursolo futursolo merged commit 4023c88 into master Jul 29, 2023
21 checks passed
@dependabot dependabot bot deleted the dependabot/cargo/indexmap-2.0.0 branch July 29, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants