Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding kitchen and chefspec and fixing package noop #38

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

winmillwill
Copy link

I was getting an error where the php-fpm package ended up being '' (the empty string) because the test to set it in the recipe uses nil? and playing with irb will show you:

''.nil?
# false
''.empty?
# true

if you doubt the changes, you need only revert the change to the attributes file and try using rspec or kitchen.

@yevgenko
Copy link
Owner

yevgenko commented May 7, 2014

👍 Thank you! Test suites is something that every project must have this days.
Please see my comment on the code, and I'm looking forward to get it merged ASAP :)

@winmillwill
Copy link
Author

knife-ec2 conflicted with kitchen and I figured people were using omnibus chef now, and .ruby_version just annoyed me, but I've switched to chruby now, so no big deal. Also, kitchen is in chefdk. To be honest, I just wanted to see if anyone would notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants