Simpify LangTag constructor

yetanalytics · Dec 11, 2024 · 9485538 · 9485538
1 parent 489c4e2
commit 9485538
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 11 deletions.
diff --git a/src/main/java/com/yetanalytics/xapi/model/LangTag.java b/src/main/java/com/yetanalytics/xapi/model/LangTag.java
@@ -22,19 +22,14 @@ public class LangTag {
      * This constructor takes a RFC 5646 formatted String and converts it to a
      * LangTag object consisting of a java.util.Locale object and the original
      * String.
-     * @param langTag The language tag String from an xAPI Statement language map.
+     * @param langTagStr The language tag String from an xAPI Statement language map.
      * @throws IllformedLocaleException when the String is not a valid language tag.
      */
     @JsonCreator
-    public LangTag(String langTag) throws IllformedLocaleException {
-        if (langTag == null || langTag.isEmpty()) {
-            String errMsg = "Cannot parse null or empty language tag String!";
-            throw new IllformedLocaleException(errMsg);
-        } else {
-            Builder builder = new Builder();
-            languageTagLocale = builder.setLanguageTag(langTag).build();
-            languageTagString = langTag;
-        }
+    public LangTag(String langTagStr) throws IllformedLocaleException {
+        Builder builder = new Builder();
+        languageTagLocale = builder.setLanguageTag(langTagStr).build();
+        languageTagString = langTagStr;
     }
 
     /**

diff --git a/src/test/java/com/yetanalytics/model/LangTagTest.java b/src/test/java/com/yetanalytics/model/LangTagTest.java
@@ -34,6 +34,6 @@ public void testInvalidLanguageTag() {
 
         IllformedLocaleException exn2 =
             assertThrows(IllformedLocaleException.class, () -> new LangTag(""));
-        assertEquals("Cannot parse null or empty language tag String!", exn2.getMessage());
+        assertNotNull(exn2.getMessage());
     }
 }