Add TODOs for SHA validation

yetanalytics · Dec 11, 2024 · 5d001c8 · 5d001c8
1 parent e3a2405
commit 5d001c8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/src/main/java/com/yetanalytics/xapi/model/AbstractActor.java b/src/main/java/com/yetanalytics/xapi/model/AbstractActor.java
@@ -15,6 +15,7 @@ public abstract class AbstractActor extends AbstractObject {
 
     //IFI
     private URI mbox;
+    // TODO: Validate that mbox_sha1sum is a SHA1, 40-char hex string
     private String mbox_sha1sum;
     private URI openid;
     private Account account;

diff --git a/src/main/java/com/yetanalytics/xapi/model/Attachment.java b/src/main/java/com/yetanalytics/xapi/model/Attachment.java
@@ -25,6 +25,7 @@ public class Attachment {
     @JsonSerialize(using = ToStringSerializer.class)
     private MimeType contentType;
     private Integer length;
+    // TODO: Validate that sha2 is a SHA256, 64-char hex string
     private String sha2;
     private URI fileUrl;