Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DS-152] CLI subcommands #123

Merged
merged 12 commits into from
Nov 9, 2023
Merged

[DS-152] CLI subcommands #123

merged 12 commits into from
Nov 9, 2023

Conversation

kelvinqian00
Copy link
Contributor

@kelvinqian00 kelvinqian00 commented Oct 5, 2023 •
edited
Loading

  • Update CLI so that subcommands validate-input, generate, and generate-post now go in the front, not the end
  • Add a -v, --validated-input arg for the output file for validate-input
  • Split CLI-related namespaces
  • Rename datasim.main namespace to datasim.cli

@kelvinqian00 kelvinqian00 marked this pull request as ready for review October 5, 2023 19:24
milt
milt approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@milt milt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer than before, and I see there is a break ver in there so we're good.

@kelvinqian00 kelvinqian00 merged commit 5ebac8a into temporal-alignments Nov 9, 2023
6 of 7 checks passed
@kelvinqian00 kelvinqian00 deleted the cli-subcommands branch November 9, 2023 17:24
@kelvinqian00 kelvinqian00 mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cliffcaseyyet cliffcaseyyet cliffcaseyyet approved these changes

@milt milt milt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelvinqian00 @milt @cliffcaseyyet