Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal.project: Remove allow-newer and SRP stanzas #1002

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Aug 28, 2024

Also enable building of test code by default and improve test output.

Before these changes the code in Git would not even compile with ghc-9.6 (using cabal). With these changes it builds and all test pass both with ghc-9.6 and ghc-9.10.

I would have updated the tests, but I do not use stack and have zero knowledge of it.

Also enable building of test code by default and improve test output.
@Vlix
Copy link
Contributor

Vlix commented Oct 27, 2024

Thanks. We should probably add builds with cabal...

But yeah, the explicit allow-newer were from 2 years ago and for GHC 9.4 at the time, so if it works without it, I'd accept this change without issue.

@Vlix Vlix self-requested a review October 27, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants