-
Notifications
You must be signed in to change notification settings - Fork 339
Add possibility to apply custom options to different flows #487
base: master
Are you sure you want to change the base?
Conversation
Might need a little more documentation about the multiple configurations but maybe we should create a cookbook as the README is already huge. |
👍 |
@sindresorhus maybe we should accept this PR which is documented, and add a new issue for the cookbook |
Sure, but this still needs a test though. |
Also needed this functionality. Patched it into my own fork, which I am using in |
@OlgaBielkina we need a test to accept your PR. Can you provide one ? |
ping @OlgaBielkina |
…support multiple target. This functionality is not implemented
Thannxxxx @OlgaBielkina! What do you think, @stephanebachelier? |
@OlgaBielkina I've reviewed your tests. I didn't get where you trigger the multiple flow. |
@stephanebachelier as far as I understand when you use multiple flows (profiles) all previous functionality should work the same. My tests show that it works for the dev profile. All except multiple targets. With previous code base it was not possible to add dev/prod profiles at all. |
@OlgaBielkina I will need to take some time to understand/review the whole thing. |
@OlgaBielkina will take a deeper look soon. Sorry for the delay there was others issues that I needed to fix before. |
Ref issue: #255