Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

Add possibility to apply custom options to different flows #487

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

OlgaBielkina
Copy link

Ref issue: #255

@sindresorhus
Copy link
Member

// @stephanebachelier

@stephanebachelier
Copy link
Collaborator

@sindresorhus 👍

Might need a little more documentation about the multiple configurations but maybe we should create a cookbook as the README is already huge.

@sindresorhus
Copy link
Member

Might need a little more documentation about the multiple configurations but maybe we should create a cookbook as the README is already huge.

👍

@stephanebachelier
Copy link
Collaborator

@sindresorhus maybe we should accept this PR which is documented, and add a new issue for the cookbook

@sindresorhus
Copy link
Member

Sure, but this still needs a test though.

@Frank3K
Copy link

Frank3K commented Dec 31, 2014

Also needed this functionality. Patched it into my own fork, which I am using in package.json now. Excellent patch.

@stephanebachelier
Copy link
Collaborator

@OlgaBielkina we need a test to accept your PR. Can you provide one ?

@arthurvr
Copy link
Member

arthurvr commented Feb 8, 2015

ping @OlgaBielkina

…support multiple target. This functionality is not implemented
@arthurvr
Copy link
Member

Thannxxxx @OlgaBielkina! What do you think, @stephanebachelier?

@stephanebachelier
Copy link
Collaborator

@OlgaBielkina I've reviewed your tests. I didn't get where you trigger the multiple flow.

@stephanebachelier stephanebachelier self-assigned this Feb 21, 2015
@OlgaBielkina
Copy link
Author

@stephanebachelier as far as I understand when you use multiple flows (profiles) all previous functionality should work the same. My tests show that it works for the dev profile. All except multiple targets. With previous code base it was not possible to add dev/prod profiles at all.

@stephanebachelier
Copy link
Collaborator

@OlgaBielkina I will need to take some time to understand/review the whole thing.
In #255 there are two kinds of demands: multiple targets and or be able to switch between dev or dist profile as you can read in #456

@stephanebachelier
Copy link
Collaborator

@OlgaBielkina will take a deeper look soon. Sorry for the delay there was others issues that I needed to fix before.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants