Skip to content
This repository has been archived by the owner on Mar 26, 2018. It is now read-only.

Add basename option #60

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

stephanebachelier
Copy link
Contributor

Should fix #15 with a different approach from PR #44
Should also help #53 as it will easier to handle by other grunt tasks, as no path will be added.

As a side note, you will see in 60c53f2 that I needed to specify each tests with filerev:xxx as I need to manipulate the grunt.filerev.summary.

/CC @sindresorhus

@madrobot
Copy link

Please merge, this is a much needed option!

@sindresorhus
Copy link
Member

I don't think this solves the problem in the right way. The option should be named base and you should be able to supply a string with a path the is the base and the resulting paths will be relative to this one.

@stephanebachelier
Copy link
Contributor Author

@sindresorhus make sense :) I update the PR.

@arthurvr
Copy link
Member

arthurvr commented Jun 7, 2015

ping @stephanebachelier - This PR needs some updates, as well as a rebase.

@stephanebachelier
Copy link
Contributor Author

@arthurvr waiting for the decision about the rewrite

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong paths in grunt.filerev.summary when a cwd was defined
4 participants