Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added jakarta namespace #1309

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

PeJetuz
Copy link

@PeJetuz PeJetuz commented Jul 15, 2024

@yegor256
Hi!
Please review, I also create PR for jcabi-parent.
I'm not really clear on whether I should add a dependency to the parent or whether it should only be in takes.
I also want to update the xml to the jakarta namespace.
takes issue 1307

@PeJetuz
Copy link
Author

PeJetuz commented Jul 17, 2024

@yegor256 I updated the XML to the Jakarta namespace. Please review.
Thanks!

@yegor256
Copy link
Owner

@PeJetuz maven doesn't build

@PeJetuz
Copy link
Author

PeJetuz commented Jul 17, 2024

@yegor256 Sorry, it's mine failed. I should have tested the build on jdk 11.
The artifact "jakarta.ws.rs:jakarta.ws.rs-api:4.0.0" is not compatible with JDK 11, only with 17 and later.
Jakarta EE 11:
This specification requires that containers support execution in a Java™ runtime environment, as defined by the Java Platform, Standard Edition specification, v17 or later (Java SE 17 or later).
I rolled back the version of this artifact to 3.1.0. Should I also create a new PR for jcabi-parent to downgrade this artifact?

@PeJetuz
Copy link
Author

PeJetuz commented Jul 29, 2024

@yegor256 Is it possible to run the build again?
Thanks!

@yegor256
Copy link
Owner

yegor256 commented Aug 2, 2024

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Aug 2, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 7fb1075 into yegor256:master Aug 2, 2024
11 checks passed
@rultor
Copy link
Collaborator

rultor commented Aug 2, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 10min)

@yegor256
Copy link
Owner

yegor256 commented Aug 2, 2024

@PeJetuz thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants