Finalize remove multi message #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of finalizing `MultiMessage` deprecation. Previously the stages support processing both `ControlMessage` and `MultiMessage` - this PR removes the code paths for `MultiMessage` from the following stages (from both C++ & Python implementation): - Pre-process stages: - `deserialize_stage` - `preprocess_base_stage` - `preprocess_ae_stage` - `preprocess_fil_stage` - `preprocess_nlp_stage` - `train_ae_stage` - Post-process stages: - `serialize_stage` - `add_scores_stage_base_stage` - `add_scores_stage` - `add_classification_stage` - `filter_detections_stage` - `generate_viz_frames_stage` - `ml_flow_drift_stage` - `time_series_stage` - `validation_stage` - Inference stages: - `auto_encoder_inference_stage` - `identity_inference_stage` - `inference_stage` - `pytorch_inference_stage` - `triton_inference_stage` - Output stages: - `write_to_vector_db_stage` The related unit tests are also updated to use only `ControlMessage`. Morpheus examples that imports stages/messages directly (rather than creating their own version) are also updated to get CI passed for this PR. Closes nv-morpheus#1887 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Yuchen Zhang (https://github.com/yczhang-nv) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) - David Gardner (https://github.com/dagardner-nv) URL: nv-morpheus#1803
…inalize-remove-multi-message
## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Christopher Harris (https://github.com/cwharris) Approvers: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) - Michael Demoret (https://github.com/mdemoret-nv) URL: nv-morpheus#1880
* Remove `TODO` statements from documentation * Add the word `TODO` to the `reject.txt` file, although due to errata-ai/vale#893 this does not guarantee occurrences will always be flagged. Closes nv-morpheus#1877 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: nv-morpheus#1879
…inalize-remove-multi-message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes
By Submitting this PR I confirm: