[READY] Prefer selectionRange over range in LSP Location-like objects #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the LSP specification uses selectionRange in only three places: 1. In `selectionRange` requests 2. In hierarchy items 3. In DocumentSymbol Since ycmd does not support the first and the third point, we can ignore them.. As for hierarchy items, `range` property is meant to span the entire symbol definition, while `selectionRange` property is meant to span just the identifier of a symbol. Note that `range` also can include a docstring preceeding a function definition. That means that `symbol[ 'range' ][ 'start' ]` might be pointing at the start of a docstring, instead of pointing at the function name. Current behaviour of the tested servers: - `clangd` and `gopls` put what should be in `selectionRange` into both properties. - `jdt.ls` and `rust-analyzer` properly differentiate these two ranges. Not handling `selectionRange` properly leads to at least two problems: 1. In hierarchy requests, the description of the root node can be wrong. 2. Requesting outgoing calls of an incoming call picks the wrong location altogether.
|
Already discussed and a different approach was decided for #1733 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the LSP specification uses selectionRange in only three places:
selectionRangerequestsSince ycmd does not support the first and the third point, we can ignore them..
As for hierarchy items,
rangeproperty is meant to span the entire symbol definition, whileselectionRangeproperty is meant to span just the identifier of a symbol. Note thatrangealso can include a docstring preceeding a function definition. That means thatsymbol[ 'range' ][ 'start' ]might be pointing at the start of a docstring, instead of pointing at the function name.Current behaviour of the tested servers:
clangdandgoplsput what should be inselectionRangeinto both properties.jdt.lsandrust-analyzerproperly differentiate these two ranges.Not handling
selectionRangeproperly leads to at least two problems:This change is