-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY] Implement type/call hierarchy handling #4221
Merged
Merged
Commits on May 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dbcca3d - Browse repository at this point
Copy the full SHA dbcca3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 93833dc - Browse repository at this point
Copy the full SHA 93833dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 705803a - Browse repository at this point
Copy the full SHA 705803aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 729806c - Browse repository at this point
Copy the full SHA 729806cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fcf89f0 - Browse repository at this point
Copy the full SHA fcf89f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65456b2 - Browse repository at this point
Copy the full SHA 65456b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08353bc - Browse repository at this point
Copy the full SHA 08353bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ce21e2 - Browse repository at this point
Copy the full SHA 0ce21e2View commit details
Commits on May 13, 2024
-
Close the popup when non-handled key pressed
This makes the popup disappear if you keep typing or enter inser mode or move the cursor etc. I found it jarring that previously it would just move the cursor behind the popup and such until you hit escape. Makes the popup more "modal" but without actually stopping you from continueing. Also: - Use simliar up/down keys as the symbol finder (c-p, c-k, c-n, c-j etc.) - SetupFoo -> SetUpFoo because the verb is "To set up" (rather than the noun "a setup". - purge barbaric 80+ character lines
Configuration menu - View commit details
-
Copy full SHA for f1937cf - Browse repository at this point
Copy the full SHA f1937cfView commit details -
We try to be a bit consistent with the finder poppup, but implementation-wise this is simpler. The idea is that there are 3 columns, each having 1/3 of the popup width. We fix the width of the popup (like we do for the finder) and set the tabstop to 1/3 of the internal width (core_width). Then when displaying text, we truncate "columnns" according to that tabstop (to avoid mess). To do this, we pass structured data from the python layer to vimscript and construct the line text there. This will also help later when we add in the syntax highlight (text properties) like we have for the finder popup.
Configuration menu - View commit details
-
Copy full SHA for c217e66 - Browse repository at this point
Copy the full SHA c217e66View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72026b3 - Browse repository at this point
Copy the full SHA 72026b3View commit details
Commits on May 14, 2024
-
Style the hierarchy popup like the finder popup
This basically involves moving the properties mapping to its own place, and creating text properties to overlap the various parts of the popup columns. Style matches, and feels correct. Fiddly part is that we have to (for some reason) set cursorline every time we move the cursor, but ain't nobody gonna be able to explain why, and why that only necessary after launching the finder popup window once. Some wierd vim bug is my guess.
Configuration menu - View commit details
-
Copy full SHA for 6ca4659 - Browse repository at this point
Copy the full SHA 6ca4659View commit details -
Trim leading/trailing whitespace from description
This makes the columns seem less broken, particularly for leading whitespace. This is particularly problematic due to our use of tabstop: if the leading whitespace was a tab, it would go nuts. It would still go nuts for any other literal tab in the description. Perhaps we should fix that too.
Configuration menu - View commit details
-
Copy full SHA for ea6cb61 - Browse repository at this point
Copy the full SHA ea6cb61View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa73852 - Browse repository at this point
Copy the full SHA fa73852View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3376c05 - Browse repository at this point
Copy the full SHA 3376c05View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a68752 - Browse repository at this point
Copy the full SHA 2a68752View commit details
Commits on May 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9d8d267 - Browse repository at this point
Copy the full SHA 9d8d267View commit details
Commits on Jun 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6c3832d - Browse repository at this point
Copy the full SHA 6c3832dView commit details
Commits on Jun 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3702f46 - Browse repository at this point
Copy the full SHA 3702f46View commit details -
Configuration menu - View commit details
-
Copy full SHA for 489dcb1 - Browse repository at this point
Copy the full SHA 489dcb1View commit details -
Fix re-rooting of call/type hierarchies
Previously, when changing direction of hierarchy and re-rooting the hierarchy tree, we would retain the old node as the new root. That works most of the time, but fails in the face of multiple inheritance and switching to supertypes. In that, problematic, case, the resulting hierarchy will be missing some supertypes. Worse, if a call hierarchy contains a node with multiple locations, re-rooting to that node behaved in a way that defies explanation. The solution is to throw away everything and start a new hierarchy completely every time a user requests re-rooting. This trades some performance for correctness, but this is not at all performance sensitive.
Configuration menu - View commit details
-
Copy full SHA for 8888bbe - Browse repository at this point
Copy the full SHA 8888bbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 546b050 - Browse repository at this point
Copy the full SHA 546b050View commit details
Commits on Jun 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 31f6517 - Browse repository at this point
Copy the full SHA 31f6517View commit details -
Fix sending requests for a location in an unloaded buffer
In order to send a ycmd request for an unloaded buffer one must first... load the buffer. That is the only way to reliably determine the buffer's filetype. However, we do not want to switch to the buffer, so everything needs to be done "in the background". `:badd` adds a buffer as unloaded, if it were not present before. `bufload()` loads a buffer that has previously not been loaded.
Configuration menu - View commit details
-
Copy full SHA for 67c02b8 - Browse repository at this point
Copy the full SHA 67c02b8View commit details -
Properly calculate selection offset when expanding hierarchy upwards
Previously all new nodes were counted as 1. With call hierarchies, there may be more locations/lines per hierarchy node. In that case, the cursorline would be set to the wrong line. Instead, we need to add up the lengths of all the item locations.
Configuration menu - View commit details
-
Copy full SHA for e354a54 - Browse repository at this point
Copy the full SHA e354a54View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e03ee0 - Browse repository at this point
Copy the full SHA 5e03ee0View commit details
Commits on Jun 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bbd0f03 - Browse repository at this point
Copy the full SHA bbd0f03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 866128c - Browse repository at this point
Copy the full SHA 866128cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 53f4a42 - Browse repository at this point
Copy the full SHA 53f4a42View commit details
Commits on Jun 18, 2024
-
Changelog: 1. Upgrade all subservers 2. Hierarchy support
Configuration menu - View commit details
-
Copy full SHA for f05f89e - Browse repository at this point
Copy the full SHA f05f89eView commit details
Commits on Jun 19, 2024
-
Previously the tests were using async result checking, but this is intended for insert mode only. In fact we were running off the end of the test and then the check callbacks were firing. Simplified by just making it the same but sequential, and replacding FeedAndCheck* with direct calls to feedkeys(..., 'xt').
Configuration menu - View commit details
-
Copy full SHA for 87939d6 - Browse repository at this point
Copy the full SHA 87939d6View commit details -
indexof was added so recently that even vim-helptag-versions website doesn't have it. Replace with a loop.
Configuration menu - View commit details
-
Copy full SHA for 2eff94b - Browse repository at this point
Copy the full SHA 2eff94bView commit details -
There were some unnecessary `WaitForAssert()` calls and unnecessary `silent` commands.
Configuration menu - View commit details
-
Copy full SHA for ac002d5 - Browse repository at this point
Copy the full SHA ac002d5View commit details -
Clean up BuildRequestDataForLocation
- `badd` is unnecessary since we have `GetBufferNumberForFilename()` - Instead of passing `location`, we can pass `file`, `line` and `column` separately.
Configuration menu - View commit details
-
Copy full SHA for 25ec3c9 - Browse repository at this point
Copy the full SHA 25ec3c9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.