Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix Russian numbers being detected as Kazakhstan numbers #188

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

rezk2ll
Copy link

@rezk2ll rezk2ll commented May 28, 2024

The problem

currently, Russian numbers are being guessed as Kazakhstani numbers.
it should display the Russian flag for Russian numbers.

Screenshot from 2024-05-28 14 24 23

since Russia and Kazakhstan share the same country code, the only way to differentiate between them is by using the area code. ( for Kazakhstan it's 600 to 799 ).

Under an agreement with Russia signed on 11 June 2006, Kazakhstan was assigned zone codes 6xx and 7xx (x = 0 to 9) under the unified plan.

What has been done

  • added Kazakhstan area codes ( starts with either 7 or 6 )
    Screenshot from 2024-05-28 14 19 53
  • changed the priority order to display Russian as the default country with a +7 country code ( required for the guessCountryByPartialNumber to change the country based on area codes )

Checklist before requesting a review

  • I have read the contributing doc before submitting this PR.
  • Commit titles correspond to the convention.
  • I have performed a self-review of my code.
  • Tests for the changes have been added (for bug fixes/features).
  • Docs have been added / updated (for bug fixes / features).

Screenshots (if appropriate):

Screenshot from 2024-05-28 14 17 24
Screenshot from 2024-05-28 14 17 07
Screenshot from 2024-05-28 14 16 51
Screenshot from 2024-05-28 14 16 38

Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-international-phone-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 1:31pm
react-international-phone-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 1:31pm

@Kamover
Copy link

Kamover commented Jul 20, 2024

MAN YOU ARE AWESOME !!!!! THX GOD!!

@KhYaroslav
Copy link

can you submit these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants