Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add take_std(in|out|err) & random sort #102

Merged
merged 6 commits into from
Aug 1, 2024
Merged

Conversation

AnirudhG07
Copy link
Contributor

Referring to issue #73, the Command:std(in|out|err) was already present in the docs.
So i added the take_std(in|out|err) under the Child sub, in utils.md

If I have misunderstood any part of it, pls do correct!
Thanks!

@AnirudhG07
Copy link
Contributor Author

Also added write_all and flush in the child. I hope they are fine...
(Why is merge showing errors?)

@AnirudhG07
Copy link
Contributor Author

Please check #103 before this. the commits here are present in that PR too(mistakenly)

@sxyazi
Copy link
Member

sxyazi commented Jul 20, 2024

Could you add some examples for them please?

@AnirudhG07
Copy link
Contributor Author

uh... ill try, it took a while for me to understand that small rust code for it(I m not familiar with rust). I'll update if I am unable too.
Rest of the things are correct??

@AnirudhG07
Copy link
Contributor Author

I added random sort in keymaps as mentioned in #70 . Is there another place it needs to be added @sxyazi ?

@AnirudhG07 AnirudhG07 changed the title docs: add take_std(in|out|err) in utils docs: add take_std(in|out|err) & random sort Jul 24, 2024
@AnirudhG07
Copy link
Contributor Author

Is it possible to merge this branch soon @sxyazi so that I can add some UI components to the docs, as i told before. otherwise the new branch will be built on top of this main and i ll face some issues dealing with commits and all.

Copy link
Member

@sxyazi sxyazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sxyazi sxyazi merged commit a7bf2a6 into yazi-rs:main Aug 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants