Skip to content
This repository has been archived by the owner on Mar 9, 2024. It is now read-only.

Add url support, handle null strings on iOS, and fix deprecated calls on iOS. #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jacobhanshaw
Copy link

Add option to pass url.
Fix reference to deprecated pop over calls in _NativeShare_Share in NativeShare.mm.
Handle null string parameters in _NativeShare_Share in NativeShare.mm.

@yasirkula
Copy link
Owner

I've skimmed through the native code but I think I need some help understanding the behavioral difference. What happens differently when I call SetUrl(url) instead of SetText(url)? Or when I call SetText("some text " + url)? Why are Messenger, Facebook and Twitter shares considered special cases?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants