Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent Q/A Sessions in Q/A Tab #20

Merged
merged 30 commits into from
Oct 12, 2023
Merged

Conversation

yashsehgal
Copy link
Owner

@yashsehgal yashsehgal commented Oct 10, 2023

@vercel
Copy link

vercel bot commented Oct 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
prepmeup ✅ Ready (Inspect) Visit Preview 1 resolved Oct 12, 2023 1:51am

…r and imported it in page.tsx, changed the values of sessionID in qna-session-mock.ts to make all of them unique
…rning array of interface to object of type array of interfaces (reference: FeatureList object from dashboard-features-list)
@yashsehgal
Copy link
Owner Author

The vercel deployment is failing @shristigupta12

Make sure you do npm run build before pushing changes.

@yashsehgal
Copy link
Owner Author

yashsehgal commented Oct 11, 2023

Changes required

  • 1. Changes in recent sessions

Here, do not use another fetch import for getting recents data.

const RecentSessionsData: Array<RecentQNASessionCardInterface> = fetchRecentQNASessions();

Instead, send this state as a prop.

const [recentQNASessions, setRecentQNASessions]
= useState<Array<RecentQNASessionCardInterface>>(
fetchRecentQNASessions()
);

  • 2. Fix the following, in recent session card

  • Fix the border while clicking

  • Fix the background color of card (gray to neutral shade)

image

Other than these changes, good work. After this, we can merge this with master.

cc: @shristigupta12 ❤️

@shristigupta12 shristigupta12 changed the base branch from master to feat/dashboard-ui October 11, 2023 20:06
@yashsehgal yashsehgal changed the title Feature implementation for QNA Sessions Recent Q/A Sessions in Q/A Tab Oct 12, 2023
@yashsehgal yashsehgal merged commit 1cd2841 into feat/dashboard-ui Oct 12, 2023
2 checks passed
yashsehgal added a commit that referenced this pull request Oct 12, 2023
* feat: dashboard sections boilerplate (#9)

* feat: created view container

* feat: created navbar for review with some fixes to be addressed

* fix: view-container type / merge conflict

* style: view container breakpoints

* fix(style): remove bg-red for testing

* style: tracking-tight for headings

* style: theme switch upgrade

* feat: page container layout, feature options added

* chore: add icons in features list data

* style: feature list responsive layout

* style: test logo in navbar

* Recent Q/A Sessions in Q/A Tab (#20)

* fix: add link support for option type

* feat: flow for new qna session

* style: sessions page header layout

* chore: add env file to .gitignore

* chore: add environment variables to shared commons

* feat: add methods for handling data requests, with mock data support

* feat: add UI for empty state, recent sessions view

* fix: created a new recent-qna-session-list component in section folder and imported it in page.tsx, changed the values of sessionID in qna-session-mock.ts to make all of them unique

* fix: changed the data of qna-session-mocks.ts file from function returning array of interface to object of type array of interfaces (reference: FeatureList object from dashboard-features-list)

* feat: a rough design of the recent-qna-sessions

* fix-styles: fixed a hover brightness style

* fix style: created a common class box-card to reduce css repitition

* feat: add component for listing items in flex

* fix: vercel key-prop issue resolved

* fix: recent sessions list rendering

* chore: feature list data shifted to common

* feat: created a box-card component in layout

* chore: changed name component-list to box-card-slider

* chore: file name changed and box-card style removed

* fix: build error fixed

* fix: build error fixed

* chore: used usestate as prop in recent-qna-sessions-list

* fix: prop error fix in recent-qna-session

* fix: Style changes

* style: update text size in recent q/a session cards

* feat: add prettier config

* chore: prettier fix

* style: remove ring on links and buttons

* style: add dialog content bg

* feat: mock data manager for topics & depth

---------

Co-authored-by: Shristi Gupta <[email protected]>

---------

Co-authored-by: Shristi Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Epic]: Feature implementations for QnA Session
2 participants