Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin-nm): handle supportedArchitectures #4343

Merged
merged 1 commit into from
Apr 12, 2022
Merged

fix(plugin-nm): handle supportedArchitectures #4343

merged 1 commit into from
Apr 12, 2022

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Apr 11, 2022

What's the problem this PR addresses?

We forgot to update the node-modules linker in #3575 to support supportedArchitectures.

Fixes #4323

How did you fix it?

Updated the linker to use this.opts.project.configuration.getSupportedArchitectures() to get the supported architectures.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz requested a review from larixer April 11, 2022 13:53
@larixer larixer merged commit 07c3421 into master Apr 12, 2022
@larixer larixer deleted the merceyz/fix/nm-supportedArchitectures branch April 12, 2022 11:22
merceyz added a commit that referenced this pull request May 12, 2022
@merceyz
fix(plugin-nm): handle supportedArchitectures (#4343)
c07e939
@merceyz merceyz mentioned this pull request Oct 1, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larixer larixer larixer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Not all linkers respect supportedArchitectures
2 participants
@merceyz @larixer