Skip to content

Commit

Permalink
BF: fix time_diff* and time_remove benchmarks to account for long RFe…
Browse files Browse the repository at this point in the history
…d revision arg etc

Only with fresh asv 0.6.0 which started to exit with exit code 2 if any
benchmark failed, we finally had to pay attention to those long failing
benchmarks. We have removed the option 'revision' so long ago but first didn't
mention and then just ignored. For that and time_remove I also made it into
dataset method invocation since otherwise it was not finding the dataset any
longer given the path to it (didn't investigate deeper).
  • Loading branch information
yarikoptic committed Oct 4, 2023
1 parent bfcc8a5 commit 0f63855
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions benchmarks/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,13 @@ def time_uninstall(self):
reckless='kill')

def time_remove(self):
drop(self.ds.path, what='all', reckless='kill', recursive=True)
self.ds.drop(what='all', reckless='kill', recursive=True)

def time_diff(self):
diff(self.ds.path, revision="HEAD^")
self.ds.diff(fr="HEAD^")

def time_diff_recursive(self):
diff(self.ds.path, revision="HEAD^", recursive=True)
self.ds.diff(fr="HEAD^", recursive=True)

# Status must be called with the dataset, unlike diff
def time_status(self):
Expand Down

0 comments on commit 0f63855

Please sign in to comment.