Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate-code and big models update #168

Merged
merged 4 commits into from
Oct 14, 2024
Merged

Generate-code and big models update #168

merged 4 commits into from
Oct 14, 2024

Conversation

GermanVor
Copy link

No description provided.

@GermanVor
Copy link
Author

yandex/cloud/cic service breaks proto generation script (I did not include it to generate-code)

@GermanVor GermanVor changed the title generate-code and big models update [WIP] generate-code and big models update Oct 3, 2024
@GermanVor
Copy link
Author

GermanVor commented Oct 3, 2024 •
edited
Loading

The inferred type of this node exceeds the maximum length the compiler will serialize. An explicit type annotation is needed. - I do not know how to solve it correctly (there were few files I fixed manually like that)

@nikolaymatrosov
Copy link
Contributor

yandex/cloud/cic service breaks proto generation script (I did not include it to generate-code)

Should be fixed in the latest cloudapi commit yandex-cloud/cloudapi@ac83786

@nikolaymatrosov
Copy link
Contributor

This PR introduces breaking changes due to the renaming of nearly all services, which affects backward compatibility. As such, these updates should be included in a new major release of the SDK.

However, the changes themselves may not be significant enough to justify a major release. It would be ideal for the new release to also address additional improvements, such as splitting the SDK code into packages and supporting different cloud regions.

@GermanVor GermanVor changed the title [WIP] generate-code and big models update Generate-code and big models update Oct 9, 2024
@DavyJohnes
Copy link
Contributor

This PR introduces breaking changes due to the renaming of nearly all services, which affects backward compatibility. As such, these updates should be included in a new major release of the SDK.

However, the changes themselves may not be significant enough to justify a major release. It would be ideal for the new release to also address additional improvements, such as splitting the SDK code into packages and supporting different cloud regions.

Согласен. А давайте выпустим альфу нового мажора!

@GermanVor можешь, пожалуйста, изменить таргетную ветку для мержа на alpha?

@GermanVor GermanVor changed the base branch from master to alpha October 10, 2024 10:37
@DavyJohnes
Copy link
Contributor

@GermanVor в feat коммите нужно сделать BREAKING CHANGE, чтобы автоматика мажор выпустила.
https://www.conventionalcommits.org/en/v1.0.0/#summary

@GermanVor
feat: generate-code and big models update
4cc0985 
BREAKING CHANGE: new services paths
DavyJohnes
DavyJohnes reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@DavyJohnes DavyJohnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А давай v1 префикс\суффикс вообще игнорить? Добавлять vX только для X > 1? Сейчас сильно избыточно выглядит.

package.json Outdated
"lint": "eslint src config",
"build": "cross-env NODE_OPTIONS=\"--max-old-space-size=4096\" tsc -p .",
"test": "jest -c config/jest.ts --passWithNoTests '.*\\.test\\.ts$'",
"lint": "eslint src/ --quiet --fix",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему конфиги не надо линтить?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d562dda

package.json Outdated
@@ -66,9 +66,9 @@
"typescript": "^4.5.4"
},
"scripts": {
"test": "cross-env NODE_OPTIONS=\"--max-old-space-size=4096\" jest -c config/jest.ts --passWithNoTests '.*\\.test\\.ts$'",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему увеличение памяти больше не требуется?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d562dda

@DavyJohnes DavyJohnes merged commit 4c594b9 into alpha Oct 14, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavyJohnes DavyJohnes DavyJohnes approved these changes

@teleginzhenya teleginzhenya Awaiting requested review from teleginzhenya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GermanVor @nikolaymatrosov @DavyJohnes