[WIP] Remove PosixTypes #648
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's good to see the Removing |
|
Yes, agreed, that's why I marked the PR a WIP for now. I wanted to see what the end game looked like before deprecating. I think I'll port the examples and tests that were removed to the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up from #624 to remove internal posix types after release of the external posix-types here: https://github.com/savonet/ocaml-posix
I tried to use the external posix types but it gets tricky as they rely on the ctypes API/ABI. It might be possible with a git module but I highly discourage it.
It should also be possible to re-export from external posix-types into the legacy
PosixTypesmodule if we feel like it'll be a good idea.I will release the external
ocaml-posixnext.