Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix existing and add missing meta-data #199

Merged
merged 5 commits into from
Aug 7, 2024
Merged

Conversation

matijapretnar
Copy link
Contributor

I've now gone through all the papers in the list and updated all of those that exist in DBLP (add DOI, BibTeX, fix typos, use official title capitalisation). I think we can consider #8 closed.

Copy link
Collaborator

@dhil dhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo question/comment.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@dhil
Copy link
Collaborator

dhil commented Aug 6, 2024

Have you used a script to generate the entries? If so, then it may be useful to integrate it into the CI as a sort of "format checker" for future PRs.

@matijapretnar
Copy link
Contributor Author

Indeed I had, but there were a bunch of one-off scripts that are slowly converging. When I'm done, I can make it available, though I do not want to be too strict with CI so to not discourage submissions.

Also, the script uses a local JSON file as a cache to avoid hitting DBLP with too many requests. Can this be persisted through PRs?

@dhil
Copy link
Collaborator

dhil commented Aug 6, 2024

Indeed I had, but there were a bunch of one-off scripts that are slowly converging. When I'm done, I can make it available, though I do not want to be too strict with CI so to not discourage submissions.

Also, the script uses a local JSON file as a cache to avoid hitting DBLP with too many requests. Can this be persisted through PRs?

I don't think we should be strict either. Such a script should simply check our existing style guidelines programmatically, it would be convenient. And yes, we can persist files by having the CI upload an artifact after a successful run.

@matijapretnar
Copy link
Contributor Author

In case anyone wants to play around with GitHub actions, here is the final script I've used to update the bibliography: https://gist.github.com/matijapretnar/926db074d96b51b8aa079f66cc785e11. I did the arXiv changes manually, so that is not in yet.

If you run it, you get the updated README.md. The uncommited changes in author names are all regressions, so perhaps it does not even make sense to rely on DBLP for CI. Perhaps you can run it every now and then to do a clean-up.

@dhil
Copy link
Collaborator

dhil commented Aug 7, 2024

Thanks! I will experiment with it at a later time.

@dhil dhil merged commit 3a781b2 into yallop:master Aug 7, 2024
1 check passed
@matijapretnar matijapretnar deleted the cleanup branch August 7, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants