Enable/disable closing dropdown via aria-autoclose attribute #230
+17
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss click target has attr dropdown-close
…g close on dropdowns. Also move check to inside closeMenu function for proper binding/unbinding click handler.
|
👍 I'd really like to see this merged in. |
|
👍 |
|
Thanks for sending this in @bgilhome and sorry for the (very) late reply. A couple things:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements current Foundation's method of specifying an aria-autoclose attribute on elements to either enable/disable closing a dropdown. Elements contained within a dropdown can be disabled from closing the dropdown by adding aria-autoclose="false".
I've also allowed specifying the attribute on the dropdown element itself to disable click on all contained elements from closing the dropdown, unless they specify an attribute aria-autoclose="true".