Skip to content
This repository has been archived by the owner on Jan 20, 2021. It is now read-only.

Adding kotoeri support (Japanese text on MacOS) #28

Closed
wants to merge 2 commits into from

Conversation

vaicine
Copy link

@vaicine vaicine commented Oct 8, 2013

This also fixes a little error when deleting text when there is no text, and a little tidying up.

Haven't tested for Chinese/Korean/other similar languages, but I believe it works the same.

@yairEO
Copy link
Owner

yairEO commented Oct 9, 2013

hey, thanks, but..I cannot merge such a pull request..
this is a big change just for one specific language, you've changed too much stuff..

@vaicine
Copy link
Author

vaicine commented Oct 9, 2013

The stuff that is relevant to japanese/chinese/korean input isn't much change, and it's only used when japanese/chinese/korean is an input. Perhaps I should have done the tidying up part in separate commits so it's more obvious what is what.

I'll post a link in issue #5 to my fork so they can use this version if they still asian input support.

@yairEO
Copy link
Owner

yairEO commented Mar 31, 2014

I'm closing this. if any Asian wants this support, he can look it up in the issues sections, but for the benefits of most users, I do not want to bloat the file size. This project was intended only for English usage..

@yairEO yairEO closed this Mar 31, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants