Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve for requirejs #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve for requirejs #35

wants to merge 1 commit into from

Conversation

sielay
Copy link

@sielay sielay commented Sep 26, 2016

Your UMD won't work with requirejs, as you expect MediumEditor to be globally available and use use strict in the same mode and then invoke your factory without reference to root.

My change will be breaking so wroth making major version.

In case of requirejs usage you'd have to inject MediumEditor like

MeTables = require('medium-editor-tables')({
        MediumEditor: MediumEditor
    });

@coveralls
Copy link

Coverage Status

Coverage remained the same at 10.821% when pulling 77310ad on sielay:master into fe1e313 on yabwe:master.

@nmielnik
Copy link
Member

nmielnik commented Feb 8, 2017

@sielay or @yazonnile any chance you could try to fix the merge conflict and push this up again? We'll be sure to get this merged quickly this time, we've been on a bit of a hiatus for a while

@jmsunseri
Copy link

jmsunseri commented May 17, 2019

I could really use this. I'm trying to use in an angular project and it's just not going to work as coded I don't think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants